branchrust_reboot/main/concurrentqueue_leakcancel
8 Commits over 0 Days - ∞cph!
Clean: remove false-sharing todo
Don't have proof of how impactful it is now in this area, so not going to jump the gun for now
Tests: none, trivial change
Undo: pick the right version of ProjectSettings from history
Tests: none, trivial change
Undo: revert ProjectSettings
Tests: none, trivial change
Bugfix/Optim: propagate fix to other ConcurrentQueues in the file
Tests: local 2-player session on Craggy in editors
Clean: remove the hack test
Now that the bug was validated this doesn't serve any purpose
Tests: compiled in editor
Bugfix/Optim: Don't force ConcurrentQueue to allocate new segments on every push
My hack/forced test no longer allocates - now I just need to cover left-over cases of this problem
Tests: on Craggy in editor took a snapshot - no more allocs in the forced test area.
Hack: improved the runaway test
Now I can see it via server profiler - ~90KB across 192 allocs for 192 packets
Tests: Craggy in editor, took a snapshot
Hack: synthetic test to proc ConcurrentQueue memory runaway
Managed to reproduce high memory allocation edge case of ConcurrentQueue. Need to rip it out after applying the fix.
Tests: ran the code and checked state of ConcurrentQueue with a debugger
