branchrust_reboot/main/duplciate_bot_id_fixcancel
5 Commits over 0 Days - ∞cph!
Bugfix: fix bot id being shared when loading a save
Fixed by reconstructing the free bot ID list and free bot id counter
Tests: playground with 1 transient and 1 persitent bot, couple loops of spawn player -> save -> load
Clean: fix formatting in BasePlayer-SaveLoad.cs
Tests: none, trivial change
Bugfix: recycle bot IDs when loading from a save
This was leaking a bunch of IDs, likely harmles on maps with low bot population
Tests: loaded craggy with preplaced bots (both persistent and transient). Spawned extra bots, their ID count was starting from 1
Bugfix: skip trying to draw water bodies if camera planes are not initialized
Was causing a lot of asserts when loading into Craggy with debug unity editor
Tests: booted craggy with debug editor - no more invalid plane normal asserts
Bugfix(editor): schedule QueryVisJobRunner jobs early to avoid editor freeze
Tests: was able to load craggy save with players multiple times in a row
