userDaniel Pcancel
reporust_rebootcancel

1,790 Commits over 457 Days - 0.16cph!

3 Hours Ago
Update: convert error logs to error-once logs The current changes mitigate the problem, which will allow peeps to play longer while we chase up what's going wrong. Tests: none, trivial change
3 Hours Ago
Update: adding more logging in an attempt to catch baseplayer NREs Tests: 2p local session with spectating, disconnects
Today
Clean: leaving a TODO note for one I return to this
3 Days Ago
Update: if either logging or dry run is enabled, log uploader activity Previously it was editor only, and you had to enable dry-run specifically to get those logs. This makes it easier to work with. Tests: none, trivial change
3 Days Ago
Bugfix: in editor with SERVER+CLIENT send client records to client gameplay AnalyticsTable Not sure if it's technicall bug, but it did differ from original logic Tests: logged activity in the editor
3 Days Ago
Optim: wind down AzureAnalyticsUploader when UseV2 is active Gets rid of async tasks that are generating allocs while waiting for work Tests: in editor activated v2, waited till upload happens, then disabled and waited for normal upload
3 Days Ago
Update: name the analytics thread Tests: dry run in the editor
3 Days Ago
Optim: reduce allocations by relying less on async/await - Use a Thread instead of a Task for internal AnalyticsManager work (this also fixed editor 10s shutdown delay) - Allow internal upload tasks to run in parallel instead of waiting on sequential completion Previously it would frequently GC, now it's back to normal Tests: ran in editor in dry run mode. ran unit tests
3 Days Ago
Update: add profiling markers to AnalyticsManager and it's uploaders Tests: ran in editor
3 Days Ago
Update: FPUploaderImpl - add a warning in case someone attempts to feed it non-json AnalyticsTable Tests: none, trivial change
3 Days Ago
Update: append AnalyticsTable name when logging accumulator activity Tests: none, trivial change
3 Days Ago
Update: accumulator log now also outputs byte size (pre compression if there is one) Tests: none, trivial change
3 Days Ago
Bugfix: fix false "EventRecord pooling error" when disabling analytics.usev2 Hoping to rip it out once we fully convert to v2 Tests: unit tests + enabled-disabled in editor
3 Days Ago
Update: move analytics-for-server shutdown to ServerMgr.CloseConnection This shuts down server before steamwroks in SERVER+CLIENT editor - makes editor's lifecycle management less confusing Tests: confirmed client session end event still fires in editor
3 Days Ago
Bugfix: ensure session end event gets enqueued for V2 analytics Tests: monitored in editor, saw it when stopping player
3 Days Ago
Clean: move new implementation into it's own file Might split it up further, but not needed for now Tests: editor compiles
3 Days Ago
Bugfix: respect rate limiters of AnalyticsTables and avoid mixing data when uploading - Fixed by creating an accumulator per AnalyticsTable that's managed by uploaders I need to profile and work on allocs, but it seems to be working Tests: unit tests and monitored client telemetry
4 Days Ago
Update: Integrate the new AnalyticsManager into existing logic - Guarded by `analytics.usev2` (default off for now) - Bugfix for rate-limiting being disabled due to mixing Now and UtcNow (whoops) - Added global `analytics.dryrun` and `analytics.log` Did a cursory test in editor using dry running and it seems to be working, but it leaks performance data into player_tick blobs. Need to reorganize accumulators again - always-aggregate isn't always valid. Tests: used above switches and monitored data flow.
4 Days Ago
Update: Add FallbackUploader - uses primary uploader if enabled, otherwise uses fallback - Added a test that checks it - DryRun is now a per-accumulator settings instead of a global overwrite - lets each uplaoder decide how to act Allows us to setup flexible chains(extra loggers, backups, etc), and more importantly we can emulate current analytics flow Tests: ran unit tests
4 Days Ago
Update: Move accumulators into uploaders - AnalyticsTests.TestUploade has logging enabled permanently to help validate things It was a blocker to implement uploader chains (which I discovered we need for server, but should be quick) Tests: ran unit tests
4 Days Ago
Clean: rename AnalyticsUploader -> AnalyticsManager Disambiguates from the internal IUploader Tests: compiles in editor
4 Days Ago
Bugfix: apply separator in json-lists aggregation correctly Tests: used accumulator logging to see what is being fed
4 Days Ago
Update: Accumulators can now log what they're being fed This revealed a bug with json concatenation, should be a quick fix Tests: ran unit tests
4 Days Ago
Merge: from server_occlusion_gen_reorder_narrowphase - Bugfix for ServerOcclusion potentially crashing during generation Tests: generated custom map that had a consistent crash and a default 4.5k procgen editor world
4 Days Ago
Bugfix: ServerOcclusion - don't schedule same SubGrid cells repeatedly for rock intersection It caused more work to be done(this saves ~13s), and in some cases even an out-of-bounds access crash. Tests: generated server occlusion cache for a 6k custom map that had a consistent crash, generated default editor 4.5k proc gen world
4 Days Ago
Merge: from main
5 Days Ago
Update: AnalyticsUploader - combine AzureBulkJsonUploader and AzureBulkCSVUploader into BulkAccumulator - this also allows to combine the 2 uploaders into 1 This enabled aligning EventRecord serialization with current system. I think this is the last change to the code, next up will updating user code and testing in "real world". Tests: ran unit tests
5 Days Ago
Update: AnalyticsTable - bring back useJsonDataObject support Tests: ran unit tests
5 Days Ago
Tests: add all Analytics Uploader tests - Covers ClientFPUploader, ServerFPUploader, AzureBulkJsonUploader, AzureBulkCSVUploader with multithread data generation - Specialized editor logging for each uploader, as it doesn't make sense to emit compressed goup ClientFPUploader will need internet connection as it relies on steam Tests: ran unit tests
5 Days Ago
Update: AnalyticsUploader - refactor how we accumulate data - AnalyticsTable no longer serializes EventRecords, that's moved to IAccumulators - Implement serializers on top of IAccumulators (Csv, Json, CompressedCsv, CompressedJson) - Uploaders automatically create IAccumulators per AnalyticsTable Still missing an accumulator that would replicate how client analytics are serialized, but now it should be easy to do. Unit tests got simplified, need to expand coverage Tests: ran unit tests
5 Days Ago
Update: implement AzureBulkUploaderImpl - uses UploadBlobAsync instead of OpenWriteAsync Not tested. Realized that current abstractions will not play well together, so gotta move a bit of stuff around. Tests: none, will do later once I start converting user-code
6 Days Ago
Update: AnalyticsUploader - implement FPUploaderImpl - add editor-only DryRun switch to log everything instead of actually sending it - IUploader.Upload is now async Tests: none, not hooked up to anything yet, that'll be next experiment
6 Days Ago
Update: AnalyticsTable - return EventRecord back to pool - amended test to check for pool usage Tests: ran unit tests
6 Days Ago
Update: AnalyticsUploader now flushes it's queue on shutdown. - Updated tests to validate everything got flushed - Fixed missed gzipstream end block serialization tracking - Fixed ever-growing memory stream Next up need to add EventRecord pooling, then gotta implement remaining uploaders, and in theory it's done Tests: ran unit tests
6 Days Ago
Update: add per-AnalyticsTable telemetry - using this telemetry to improve unit tests Next up need to add support for flush-on-shutdown Tests: ran unit tests
7 Days Ago
Update: Initial rewrite of the analytics core - Only implements NullUploader, I'll implement actual uploaders after tests are good - Added basic tests for it, but they don't validate anything - that'll be next. - Renamed existing AnalyticsTests.cs to Test.EventRecord.cs (+ internal rename) - those tests validate EventRecord serialization Goal is to use one implementation to cover needs of both Client and Server. Got the basics done, need to add telemetry to be able to test better, support EventRecord pooling and implement the existing uploaders. Tests: ran new unit tests
7 Days Ago
Merge: from baseplayer_vis_nre - Potential(low chance) bugfix for NRE on spectate end - Breadcrumbs in case it's not fixed Tests: editor and standalone build spectating loop
7 Days Ago
Clean: remove hacky testing code changes Tests: editor compiles
7 Days Ago
Bugfix: potentially fix BasePlayer Vis NRE - Added extra logs to catch other sources - Refactored code to extract invariant checks Not confident it'll actually solve it, if it does - can remove extra logs Tests: using spec_loop command to force client to quickly spectate-then-stop in a loop. Tried both in editor and standalone builds - no issues(though I couldn't repro it originally this way anyway)
7 Days Ago
Merge: from main
10 Days Ago
Merge: from main
10 Days Ago
Update: don't build UI bundle for server bundles Tests: none, trivial change
10 Days Ago
Clean: get rid of StoreTakeover internal warmup count It never goes past 1 since we fixed open order of store Tests: stuck an assert and validated poked at different menus
10 Days Ago
Bugfix: ensure StoreItemGrid caches local source bundles Fixes wrong imges displayed in the shop for specific items Tests: navigated to store and clicked a bunch of pages. Compared before and after images
10 Days Ago
Update: reimplement UI_StoreItemGrid population - Warmup completelly skips initialization of tiles - Expanded the interface to permit existing custom usage (filtering via search, editor test tools) Tests: Clicked through a bunch of tabs and tiles, used search
10 Days Ago
Update: remove extra CacheBundleIcons calls from store tabs Previously were needed because tab could open before the store - since it was fixed, it's unnecessary Tests: navigated to store tabs - no errors
10 Days Ago
Clean: StoreItemGrid.Warmup -> OnOpened Review feedback pt 2 Tests: none, trivial change
10 Days Ago
Clean: rename WarmupIcons to CacheBundleIcons Review feedback pt1 Tests: none, trivial change
11 Days Ago
Backup 2
11 Days Ago
Update: reimplementation of UI dynamic bundle Only bundles 2 prefabs - Store and Inventory. This removed the need for editor-users to worry about what should be in which bundle. Doesn't work yet - inventory is borked, scrolling in store as well, and not unloading as much as I expected. Going to try to tweak it to see if it's usable. Tests: built standalone and took snapshots