branchrust_reboot/main/playervoice_allocscancel
14 Commits over 0 Days - Infinitycph!
Bugfix: StringView - fix invalid substring offset calculation in EndsWith overloads
Tests: unit tests pass, empty bind command works
Update(tests): add unit tests that can catch invalid substring calls in StartsWith/EndsWith
Tests: ran them, EndsWith fail (as reported)
Clean: remove a missed todo note
Not worth the effort to chase it, current code is okay
Tests: none, trivial change
Merge: from client_clientrpcs
Optim: avoid buffer alloc on recieving player voice packet
Tests: 2p on craggy, tested voice in both directions
Clean: Get rid of all manual BaseEntity.ServerRPC calls, rely on codegen instead
- rewriten some calls to not rely on generic ServerRPC
- Rust.SourceGenerator.Rpc from 9db9e963 (not merged to main yet) - has support for all NetWrite.Write types
Tests: compiles
Merge: from main
Need to rebuild Rust.SourceGenerator
Clean: remove NetWrite.BytesWithSize(byte[]...) overloads
Tests: editor compiles
Clean: remove acouple obsolete things
- Get rid of IStreamReader/Writer - they're not used anywhere
- get rid of NetWrite.Bytes(byte[]) overload - superceded by Bytes(ReadOnlySpan<byte>)
Tests: editor compiles
Update: in progress work to support ReadOnlySpan<byte> in NetWrite
- Rust.SourceGenerator updated to support ReadOnlySpan<byte>-like types in RPC sigs
- NetWrite pipes most byte[] calls to ReadOnlySpan overload
Still need to cleanup and figure out if IStreamWriter is needed
Tests: editor compiles
