branchrust_reboot/main/serverprofiler_misaligned_depths_export_fixcancel
7 Commits over 0 Days - ∞cph!
Bugfix: don't overwrite callstack depths for frame 0 with values for other frames when multiple frames are found
Tests: ran Export2FramesTorn - it passes and looks correct-ish (same wrong offset as in Export2Frames)
Bugfix(tests): fix invalid test logic in ExportExtraEnd2Frames
- renamed ExportExtraEnd2Frames to Export2FramesTorn
- added Export2Frames (shows invalid frame start - this is new)
Tests: ran unit tests, failures where expected
Update(tests): add ExportExtraEnd2Frames
Test passes but looks incorrect
Tests: ran unit tests
Bugfix: potentially support exporting profile of Recorder started inside a method and finished outside
Need to write more tests to validate it works across frames - not confident about it.
Tests: ran ExportExtraEnd - passes. ran all others - still valid
Update(tests): emit valid timestamps when running profile exporter tests
Tests: confirmed seconds-scale ranges in perfetto
Bugfix: handle cases where main thread doesn't have any profiling marks
Veeeeeeery unlikely event to happen, but should be supported
Tests: ran ExportEmptyMainThread test - it now passes
New(tests): ProfileExporter unit tests
Synthesizes basic profile streams and sees if it sucesfully exports them, without checking contents.
Tests: ran tests, 2 fail. inspected some outputs of passing ones