Refactoring Cleaning Notes for future Remove unsued

Remove Entity.,EyePosition, Entity.EyeRotation, Entity.EyeLocalPosition, Entity.EyeLocalRotation, Added Entity.GetAimRay() Delete StandardPlayerAnimator, PawnAnimator

Remove Map.Camera, add global Camera Don't use EyeRotation for view angles - because it's laggy and fucked and I'm gonna remove it

DevCamera tweaks

Delete CameraComponent

Delete CameraSetup Delete CurrentView Use Map.Camera in place of CurrentView Remove dof and motionblur from ViewDesc Add Local.UserPreference.DefaultFieldOfView Fixed main SceneCamera not controlling the render properly Remove SharedRendering/SetDevLayer hack

GameController becomes GameManager

Obsolete [UseTemplate] so we appreciate the scope of removing it Move Event.Frame to Event.Client.Frame, add ToolEvent.Frame Add Event.Client.PreCamera, PostCamera Move Event.BuildInput to Event.Client.BuildInput Move default BuildInput to internal BaseGameController Rename files to match new classnames

Make CameraSetup internal Delete FixedCamera.cs Delete LookAtCamera.cs

Vector2.Dot returns float Vector3.Equals doesn't use AlmostEqual, but the == and != operators do Move a bunch of stuff from Client to IClient, PlayerId is now SteamId Client.Pawn is an IEntity Game becomes GameController, added Sandbox.Game namespace Move stuff from GameController to BaseGameController where possible Remove Sandbox.Hooks Rename CameraMode to CameraComponent

Latest from valve

Squashed commit of the following: commit f5d20681b7389cd09e9c877d4ea0d9e260762a44 Author: Rubat <3299036+robotboy655@users.noreply.github.com> Date: Mon Dec 5 21:48:02 2022 +0200 Delete Sandbox.Internal.Decals commit c9ed0a3acf8a248f4533109ddb63edba3a3c5330 Author: Rubat <3299036+robotboy655@users.noreply.github.com> Date: Mon Dec 5 21:43:19 2022 +0200 Remove obsoletes Removed Sandbox.SpotLightCone Removed Sandbox.SceneSpotLight.SpotCone Removed Sandbox.UI.DataSource.ArraySource Removed Sandbox.UI.DataSource.BaseDataSource Removed Sandbox.UI.DataSource.BindMethod Removed Sandbox.UI.DataSource.Property Removed Assert.True( bool ) in favor of Assert.True( bool, string=null ) Removed Assert.False( bool ) in favor of Assert.False( bool, string=null ) Removed Vector3.LerpTo( Vector3, float ) in favor of Vector3.LerpTo( Vector3, float, bool = true ) Removed Vector3.LerpTo( Vector3, Vector3 ) in favor of Vector3.LerpTo( Vector3, Vector3, bool = true ) Removed Sandbox.DecalSystem Nothing should be named "dynamic.*" anymore protocol++

Experimental / PoC Limit stored custom inputs to a maximum of 256, removing older entries as new ones are added Added ButtonState intended for use with [ClientInput] Use TypeDescription to fetch property for [ClientInput] Add extensions for reading/writing Transform Add Transform.Read and Transform.Write Add support for Transform to [ClientInput] Added ButtonState.Pressed and ButtonState.Released with docs Fixed compile error from copy paste 🥴 Make ButtonState a struct again but add a method `Set` so it doesn't need to be a class for the property Revert "Make ButtonState a struct again but add a method `Set` so it doesn't need to be a class for the property" This reverts commit 6d29a14ea85614a2c91c8f670f73e5ebb30e60cf. Fixed IsDown / WasDown and also Pressed / Released being swapped Delta values for some stuff (only send stuff that changed since last cmd) Tidy up + add ManagedInputs Rename to PawnInput Just use TypeLibrary as its cached anyway Add comments + use TypeLibrary Add HasAttribute<T>() Merge branch 'master' into custom-client-input Don't add const to ArgPointer if asref is specified Rid of CUtlVectorByte in favor of direct byte arrays Make ButtonState a struct with implicit bool conversion Write dynamic assembly hash to managed input message. Check hashes match when deserializing, if they don't skip that input Merge branch 'master' into custom-client-input Prepare to move a bunch of stuff from user cmd to managed. Clear out eye angle stuff Start stripping out stuff that'll need implementing on pawn Merge branch 'master' into custom-client-input Match structs Input.LookDelta and Input.MoveDelta analog inputs + copy PawnInput props in MimicBot from target client Update (obsolete) player and controller examples to use the managed input / pawn inputs Try stripping out InputBuilder and see how it feels... Merge branch 'master' into custom-client-input Some extra docs + rename PawnInput to ClientInput Remove redundant inputs. Reverse yaw for bots Some additional documentation Move MimicBot to base addon Write -1 if entity is null Add ActiveChildInput and ensure children get added to Inventory on ClientSpawn so they match Merge branch 'master' into custom-client-input Merge branch 'master' into custom-client-input Merge branch 'master' into custom-client-input Can pass RenderAttributes into VertexBuffer.Draw Avoid conflicts Merge branch 'master' into custom-client-input Add Tony's change for always record voice in VR Merge branch 'master' into custom-client-input Merge branch 'master' into custom-client-input Merge branch 'master' into custom-client-input Remove code I added that wasn't needed Merge branch 'master' into custom-client-input Merge branch 'master' into custom-client-input Merge in Matt's Input.Pressed fix for when FPS is lower than tick rate Merge branch 'master' into custom-client-input Merge branch 'master' into custom-client-input Make sure StopProcessing is reset in Input.Process so that it isn't remembered next time Ensure InputDirection client input is consistently set to Input.AnalogMove for parity with old system Merge branch 'master' into custom-client-input Support extra types Merge branch 'master' into custom-client-input Merge branch 'master' into custom-client-input Merge branch 'master' into custom-client-input Merge branch 'master' into custom-client-input Merge branch 'master' into custom-client-input Merge branch 'master' into custom-client-input Early out if no managed inputs to write Additional types Merge branch 'master' into custom-client-input Merge branch 'master' into custom-client-input Merge branch 'master' into custom-client-input Merge branch 'master' into custom-client-input Merge branch 'master' into custom-client-input Merge fixes incompatible Merge branch 'master' into custom-client-input Merge remote-tracking branch 'origin/custom-client-input' protocol++ Remove obsolete

Unit test fix

Disable api protection unit tests (we're breaking the api now) Api++

Remove Package.Query Clean up + document protocol stuff in c# Pass api protocol when querying packages

Oops, unmangle engine.def

Moved network and api protocol into src/common/protocol.h, deleted unused version stuff

This test is a bit subjective, lets give it more breathing room

Fix potential NRE in Panel.TickInternal() OnAssetFileChanged doesn't throw an exception when the file was deleted Handle and report template parsing exception Fixed exception reporting wrongly classifying old addons as engine exceptions Fix menu exceptions getting ignored Error reporting classify tools propertly Update exception dsn

Fix editor crash on exit (causing layout to not save)

BuildShaders.bat needs to build the whole resource system now because shaders and resources. So do that.

Build rendersystemempty when building shaders

Copy over changes for shader resources Remove old .vfx, .vcs Forgot some vpc files Build content Update assettypes.txt Update resourcecompilersystem.cpp Forgot shader asset type images Impl GetErrorResource for shader type manager so we get an error shader when shader can't be found Enable all modes for error shader Recompile all core shader resources from master Update high_quality_reflections shader Recompile base shaders Update Graphics.Paint and PanelRenderer Update shaders.def Make damn sure all shaders are packed from vcs from master Material doesn't grab shaders from resource system anymore until I figure out why it was fucking up Switch back to using resource system to get shaders for material, remove vfx dictionary Free shaders for static combos that have zero ref count Destroy static combo shaders when deallocating shader resource Create all modes for error material.. again Switch to error resource if setting up static combos for mode fails Switch to ResourceIsError for other places that need to check if a shader is error Remove deallocate logs Simplify mat_reloadshaders, just do a shader and used materials blocking reload Fix assert on material layer destructor, static combo ref count should be fine to be zero here, we probably should reloaded shader update all_shaders.txt Allow access to material attributes without asserting, if modes have loaded Delete me_shaderselect.cpp Don't publish core/*.shader to steam 🦆

Don't publish core/*.shader to steam 🦆

Don't ship core/*.shader files to steam

Fix crash when closing console and restoring default layout Fix unable to close/open game view dock Arrange View/ menu alphabetically Fix gameframe fullscreen

Update Facepunch.SymStore.exe

Update Facepunch.SymStore.exe

Revert "Fixed an issue with bind proxies change detection" This reverts commit 25876a3af2d31f764e5ccbcc3774b36b39b992e1.

Added upgraded docking system

Add console dock

Compile fix

Fix ParticleSnapshotVertex_t being incorrect Hammer API: Add event Selection.OnChanged which fires when your selection set changes Fix crash with Hammer.MapAsset when there's no map asset Hammer Asset Browser: Add @selected and @inmap tag filters https://files.facepunch.com/matt/1b2911b1/sbox_zPl9iqmF1Z.png @selected shows map mesh materials too Add Hammer specific locations to asset browser for Selected, In Map, Prefabs https://files.facepunch.com/matt/1b2911b1/sbox_CTSLP9Ccz5.png Hammer: Make default Asset Browser the C# one, label legacy as legacy and tuck it away in View -> Toolbars Don't cock up MainAssetBrowser with double spacing Fix not being able to load maps by path, usually from launching map with Hammer or building cubemaps Fix SceneSunLight using invalid native pointer Don't obsolete Texture.CreateArray, 2d texture arrays and 3d textures aren't the same thing Actually hook up a count for TextureArrayBuilder to work.. Updated to .NET 7.0 and C#11 Please update Visual Studio if you're experiencing issues with it. Read more about what's new here: https://devblogs.microsoft.com/dotnet/announcing-dotnet-7/ Skater Helmet Reskins White Checker and Camo Skater Helmet skins Sorting out the Sub categories of the tops and bottoms Hammer: Update sound(scape) drop targets to use file paths Also allows drag'n'dropping asset.party soundscapes. Map compiler does not complain about invalid format of unset sounds Fix handle leak in RenderTools.ResolveDepth/FrameBuffer causing huge vram leaks when using glow Fix compiler refs to System.Security.Cryptography, in .NET 7 they've merged the 5 dlls into 1 Merge branch 'master' into updock

Rename to DockManager Allow toggle docks on and off

Baseline fixed source Remove DockWidget, replace with new DockManager Fix logs not saving in log folder Dock state save/restore

Show facets in asset browser https://files.facepunch.com/garry/ad56d755-b646-4e12-a854-f43e1b1cad49.png

Asset Browser handle spaces better https://files.facepunch.com/garry/0c89437d-84c0-439e-85e5-6fb5e5232f8b.png

Asset party type selector Move TagPicker to TagPicker files Fix NRE when hotloading after closing hammer TagEdit - updated asset browser & publisher https://files.facepunch.com/garry/cfb1e92e-6654-43c7-95ec-b587a7fe34b4.png

Diagnostic fixes Move Debug Overlay options

Compiler diagnostics

Add Sandbox.Utility.DisposeAction More startup time diagnostics Hotload diagnostics

Startup time diagnostics

Double click project row to open properties Package Settings page Use project settings window to configure asset packages Project publish wizard foundation Enforce/Signal package ident length to avoid silent fails Get rid of IWebProgress, add simple action callback instead New publisher works Delete old PublishWindow Merge fix Upload wizard fixes Clean up and make it all work for non single file projects Clear the package cache after successful upload so it'll be usable immediately Delete PackageSettings page, replace with button

Add ContextMenu which automatically deletes itself on close. Try to use this whenever popping up a one time context menu. Move Project Enabled context menu option to first position Return early in DrawTextBox if rect is invalid Sully the project list with stats and warnings

New package facets api replaces categories

Fix Shape Buffer not being generated and being cleared at wrong moment Prototype directional AO, fix reflections not showing up on shaders Send proxy mesh info as proper capsules rather than ellipsoids (which has always been silly), unify debug overlay code for them implement capsules in shader, encode directionality https://i.imgur.com/RMaTU6Q.png Implement capsule shape on reflections too https://i.imgur.com/ZEf0dxa.png Unify all aoproxy code so it's not a mess all around, makes it easier to add new shape types, add stubs for cylinder aoproxies Cylinder aoproxy meshes https://i.imgur.com/T36lRDH.png Dot product with geometric normals to avoid double occlusion on AO, fixes most artifacts Remove edge artifacting with ambient shadows https://i.imgur.com/GV8SXq3.png Misc tweaks and fixes, set default AO distance to 40, better self occlusion filter Move reflection compositing code to base code, add option to check if high quality reflctions are enabled to shader without a combo Disable aoproxy caching on models with animgraphs update shader objects Cleanup, better do vignietting Finish directional AO code before cleanup, use lightmap directionality if we are compositing to one Fix aoproxy shapes of most standard props Add support for high quality reflections in Complex shader Add high quality reflection option to complex Cleanup directional AO, have softer vigniette Some more prop aoproxy adjustments Fix flickering on directional AO probes Readd AOProxy instancing, batch AOProxies by LPV Increase precision of SDF tracing fixed holes and added LODs to the telegraph pole AssetSystem & GameData docs Sort asset references in inspector by type and name Makes it easier to see what's what. Also reduced vertical whitespace a bit. Added confirmation popups for deletion of assets/projects This also lets the user know what exactly will happen to the asset and project files upon removal/deletion. Fixed certain assets showing 2 icons in the browser AssetType.PrefersIconForThumbnail is now set correctly Remaining asset type/system docs More documentation Add SetRemoteDestination to trigger_teleport Validate organization thumbnails for asset.party selectors Validate AddonSelectorDialog org thumb - we've got 3 panels doing the same thing here, I'll unify them in the next couple of days Added multi-select support to Hammer's Entity Tool selector https://files.facepunch.com/devultj/1b1911b1/sbox_6eFNVff4fk.mp4 Removed GameSelectorDialog, renamed AddonSelectorDialog to PackageSelector Solves #621 PackageSelector uses Package.FindAsync Api Only try to sample from reflection buffer if we have reflections defined at all on the shader Add SceneParticles.SetControlPoint for rotation and transform Move ParticleAttachment to engine, this is something we'll need in tools, not just game Revert "Move ParticleAttachment to engine, this is something we'll need in tools, not just game" This reverts commit 1c9df82ec6bb1371f321125a19b915be853016eb. Add Application.CursorPosition setter (used for locking cursor in tools) Put ShapeManager on SceneWorld rather than in a singleton, fixes flickering with multiple panels Revert some experiments that shouldn't be in this branch Update shader files Sample default direction if we don't have a lightprobe Fix VR perspective on directional AO and reflections Menu: Open video settings navlink by default Partial fix for audio breaking when sounds are played really far away Documented BaseItemWidget Actions, added ItemDeselected, ItemsSelectedTo Remove AddonProperty, replaced usage with PackageSelectorProperty, added defaultSelection to PackageSelector, added placeholder UI to see current selection https://files.facepunch.com/devultj/1b2011b1/devenv_OUH7xVz5AK.mp4 PackageSelector: Re-added #local to local packages Citizen/clothing: disabled jiggle on hard hat ModelDoc: Added more info to "not in CONTENT folder" error message Added hotload_log engine convar New Dress + New Hair Fixing LOD1 of Tactical Vest Show all leaderboards in menu again Basic support for {map} leaderboard name substitution Only supported for MapSelect.Official Avatar screen subcategories and clothing variations (#626) Adds Parent to the Clothing GameResource Clothings with a Parent will be displayed as a variation in a separate panel Categorizes clothing items by their subcategory Updated a few items to have subcategories and parents Limit main menu leaderboard list to 5 items for now Hammer: Ability to reset selected material Asset Brower: Make disabled asset types a bit easier to read Prettify FBX asset name Add Model.AnimationCount and Model.GetAnimationName Add tooltips to collapsed sidebar of entity selector Add Model.MaterialGroupCount and Model.GetMaterialGroupName Complete fix for far away audio from breaking our sound system Closes sbox/issues/615 & sbox/issues/622 & sboxgame/issues/issues/2461 Set max height for package description in menu For sboxgame/issues/issues/2575 fixed cctv_globe/mount mesh orientation and naming, updated physics and prefabs Merge branch 'master' of sbox Clothing Outfit Orginised / Parented for Colour Variations Remove Compiler.ReportCompileDiagnostics - this was only used in non-tools mode and was double printing something already handled in CompileGroup Merge codegen diagnostics into Compiler.Diagnostics so errors/warnings show in editor error list or console in non-tools If codegen reports any diagnostics of error severity, fail the build ( warnings won't fail the build ) Don't run with rendersystemdx11 at all for content building, merge results on finish rather than on batches, reduce number of processors for testing Clean up some generator diagnostic descriptors, make them more clear, set severity to warning on warnings.. Non-static ConCmd.Client errors Add scrolling to leaderboard list in menu Always use addon map list for map leaderboards in menu CI worked perfectly with the previous thing, let's try without processor throttling Add -skiprendersystem param instead of forcing to it, map resourcecompiler needs GPU Merge pull request #614 from Facepunch/aoproxies-suck AOProxies Rework Fix addons targeting local projects erroring - don't use #local in addon compiler references, there's code further down that will favour local package If an addon doesn't target a specific game add a reference to base - Sandbox.Internal.AssemblyModifier seems to take care of all the references Organising of Hair / Parented + New Baseball Cap reskins Entities can use GameResource types in properties Styling consistency for game frame comboboxes Hovering asset list will show asset path in status bar Fix directional AO shipping without actual directionality Delete created sound(scape) entity when drag'n'dropping outside of a Hammer view Fallback code for Hammer drag'n'drop assets with spaces in their path Merge branch 'master' into facets

Use remote api

Fix layout not rebuilding when scroll is being constrained Fix exception when no packages

Package sidebar functional Fix hover/active not always refreshing the styles More detail when can't decode image Fixed text styles lagging behind everything else Local packages