branchrust_reboot/main/ui_store_slim_ram/storetakeover_iconscancel
7 Commits over 0 Days - ∞cph!
Bugfix: ensure ui/store.bundle gets unloaded after all changes
- UI_Store opens the first tab during warmup, outside of OnOpen, which unbalanced subscribe/unsubscribe calls. It also never closed the tab when itself being closed. Addressed both.
Tests: clicked through tabs, then closed shop - no asserts fired. Need to test in bundle mode, that'll be next.
Bugfix: fix some items showing empty icons
Tests: navigated through all tabs of shop and inventory - everything seemed present
Merge: from fix_missing_takeovers
Images still missing - digging deeper
Tests: navigated to store
Bugfix: warm up UI_StoreTakeover's Takeovers in more cases
- Reimplemented warmup of StoreFeatured/General/Limited to first spawn empty tiles and fill them up once tab is opened
Turns out, we can open tabs of store without opening store itself, resulting in an access to uninitialize takeovers. Couple empty item icons remain, will fix next.
Tests: navigated to the store and clicked through bunch of tabs and scrolled around.
Update: break ItemStoreTakeover links to sprites
- Added warmup-cooldown to relevant UI screens
Doesn't work correctly - menu spawns, but uses wrong assets. This is due to warm-up logic running before storetakeover warmup
Tests: navigated to Store and Inventory pages. Inventory is okay, but store is derped
Update: UI_StoreTakeover.AssignStoreBundle utility to assign it's icons to ui/store.bundle
- Ran Assign Store Bundle on all takeovers
Tests: inspected meta changes
Update: ItemStoreTakeover - stores paths to icon textures
- Updated StoreTakeoverDrawer to visualize sprites from paths instead of ItemStoreTakeover fields
- ran update paths on relevant prefabs
Not decoupling sprite fields from ItemStoreTakeover just yet - gonna do it as a separate submit
Tests: interacted with prefabs in the editor, confirmed that it's rendering correct images and paths are present
