branchrust_reboot/main/ui_store_slim_ram/storetakeover_icons/merge_with_atlascancel
17 Commits over 0 Days - ∞cph!
Clean: replace a path with a named constant
Tests: editor compiles
Clean: remove dead UI_Store::overlayPages variable
Tests: editor compiles
Update: don't open first tab during UI_Store warmup
Helps avoid early bundle loads
Tests: interacted with the store in editor
Bugfix: fix NRE when clicking packs on DLC screen
- DLC screen now uses path proxies for prefabs
- also fixed database backend not tracking release refcount properly (funny I made this mistake twice >.>)
The overlay prefabs are assigned to ui/store.bundle, which when unloaded breaks the stored reference.
Tests: in editor navigated to dlc page and tried clicking on all tiles - all opened as pages
Update: activate path proxies for UI
- fix a bug with UI_SteamInventory using released textures
This CL breaks prefab and texture dependencies. Going to validate standalone next
Tests: using bundle backend, interacted with store in editor
Update: resave assets for ui/store.prefab
- Still contains both path proxies and original objects, in case I'll need to chase up some sort of desync in upcoming test
Tests: activated proxy path code and tested in editor(by inspecting prefabs and ensuring they assets) and non-bundle playmode(by going through a bunch of tabs in store)
Bugfix: avoid closing already-closed page
This fixes an issue where we tried to unsub from dynamic bundle without loading it first
Tests: started in editor and navigated to shop
Buildfix: get rid of dead code call
Tests: editor compiles
Bugfix: path migration fixes
- get rid of UI_StoreItemOverlayPage paths, since they're not used atm and might not be needed
- make sure Takeover's page prefab gets assigned the right bundle
Update: overwriting all modified assets with copy from main
Tests: none, will upgrade them next
Merge: from main
Will need to copy all prefabs from main in next CL to ensure nothing's tarnished
Update: can now use PathProxyFor attribute to automatically show an asset picker for a string property
- converted StoreTakeoverDrawer to use it
Tests: enabled the path drawing paths and made sure it renders and interacts correctly
Update: StoreTakeoverPath - generalize DrawSpritePathField into DrawPathProxyField<T>
- fixed DrawSpriteField not matching how it used to be
Need to extract it from StoraTakeoverDrawer as it'll be useful in other places, will do that next
Tests: visualized takeovers in editor. Prefab picker is empty (shame) but drag-and-drop works
Update: StoreTakeoverDrawer - path proxy drawer now draws like a sprite field
- fixed drawer using wrong fields for icons
Tests: tested on cached Path override, clicked to get a cprite picker, drag and dropped - all work
Update: general cleanup and make StoreTakeoverDrawer draw original props
- StoreTakeoverDrawer used if-deffed-out blocks to be able to switch from Textures/Prefabs to paths to them
- removed Tile Override path, as it hasn't been implemented fully yet and has been silently failing this entire time
Managed to confirm that the data from Main got preserved, but I'll need to do a raw copy of prefabs with configs just to make sure nothing slipped through the cracks.
Tests: navigated to takeover configs and explored them
Merge: from main
Testing to see if I can upgrade data this way - that'll be next CL
Tests: compiles in editor
Update: restore ItemStoreTakeover serialized layout
- should allow to merge-and-upgrade all prefab changes, I hope. Will remove it post-merge.
Tests: editor compiles
