branchrust_reboot/main/instrumentscancel
591 Commits over 184 Days - 0.13cph!
Cleaned up an unneeded list
Improved instrument performance while playing back recordings that include massive amounts of notes
Adjust velocity calculation when opening .mid files
link.xml for Midi library
Fixed Musical Maestro achievement counting static instruments at compound as unique instruments (will take effect after a wipe)
Added a fallback in case these extra instruments had already been tracked
Fix typo in xylobone name (will need phrase rebuild)
Merge support for natively playing .mid files
Rename sustainPedal convar to processSustainPedal and default to On
Expose sustain pedal option in Experimental settings
Rename midiInput convar to processMidiInput
processMidiInput now defaults to on
Moved MIDI Input toggle from Experimental section to Controls section in options
Add left and right hand prop rotation offsets for instruments
Fixed drum IK hits working in local space of IK target and not local space of instrument
Added a hit rotation vector that applies an IK rotation offset when hitting a note
Exposed instrument keybinds in settings
Exception fixes
Exposed a default note to play on Primary and Secondary Fire
Can now create an arbitrary number of IK positions for an instrument
Added an IK target property drawer to help assign targets
Added context menu options to add left and right hand IK points
Added support for right foot IK control (for drumkit)
Left and Right Hand props can now be used if IK is disabled on the InstrumentKeyController (for cowbell hand setup)
Ignore stop note RPC on controlling player
Pass RPC into new PlayNoteRPC and StopNoteRPC on Key Controller
Fix RPCHandler not being assigned
Moved InstrumentKeyController RPC to InstrumentTool and StaticInstrument
Moved InstrumentKeyController components onto the weapon/mountables
Added UpdatePlayerModel virtual methods on HeldEntity and BaseMountable to modify IK while an entity is in use (removes an Update call on KeyController)
Update all instruments with new components
Manifest update
Removed some more xml comment blocks
Fixed CLIENT/SERVER compilation
Hooked up new jerry can guitar
Revert acoustic guitar to legacy guitar
Set icons to null on instruments that have no icon
Cowbell world model + Icon
Update guitar with new model + Icon
From code review:
Move hand props to Key controller to solve sticks being left on player model during pool
They get positioned during IK pass and never actually parented to the player
From code review:
_mounted is now populated on the client and server, and GetMounted() is now a shared method
This removes the need for UsingPlayer so that was removed
▅▍▌▋▆▌ ▊▉▍▉ ▋▆▌▋▊▌▄▌▍ ▊▊▇ ▇▄▋▊▊▅ ▍▇ ▆▆▆▍▍▆, █▅▌▆▅▌ ▍▄▌▍▋▇▊▋▅ ▍█▇▌▋▉▋ ▍▊▅▉▉▉
Fixed icon import settings for new instruments
Added an ItemIcon Import settings preset
From code review:
Reset mountedSpineLookWeight
Removed some xml method comments
Disable saving on key controller child entities
Remove cachedPlayer and SetPlayer() from InstrumentKeyController
Icons for Trumpet, Flute, Tambourine, Drum Kit and Bass
Trumpet and bass are third person
Reparented instrument view point to spine_4 to work with trumpet hold type better
Merge from third person held
Allow some rotation around the locked camera perspective (about 20 degree son both axis) on static instruments
Exposed and lowered IK lerp speed
Added some editor handles for easier IK placement
Equip drumsticks when using drums
▍▉▇▆▉ ▇ ▌▄▄█▌▇▉▅▌ ▋▌▍▉▉▆ ▅▄ ▇▍▇▅▇▆▋ ▅▄▄▄▆███ ▍▊▌▋ ▅▄▇▊ ▉▅▌▉▇ (█▇▉▍▌█▍▇ ▅▆ ▉▌▆▇▋▇█)
Rework drum kit prefab and build manifests
▅▅▌▄▋ ▆▅▉▅ ▍▌▊▆▇▇█ ▉▊▅▋ ▆█▉▄█▋▆ ▄▅▊ ▉▅▄ ▊▄▋▄▆▇
