branchrust_reboot/main/instrumentscancel
591 Commits over 184 Days - 0.13cph!
Fixed MIDI input sending RPC's even if a note was rate limited
Added a max of 5 MIDI notes started in a frame
Move AllowFullKeyboardInput to the NoteBindings object, should fix full keyboard mode not working on compound instruments
Enable sustain on piano
Possible Exception fix on InstrumentViewModel
Added support for sustain pedals on MIDI keyboards
Fixed IKNoteTarget drawer not appearing
Play deploy animation when mounting a piano
Remove some placeholder tambourine and cowbell stuff
Move instruments audio group so that it's not underneath game sounds
Make notebindings non-serialized, pass in Binding info when required
Print bind count on instrument and BindingCollection in instruments.midiinfo
Increased max concurrent notes on the piano to 10 (was 3)
Update animation slots on trumpet
Fixed some duplicated notes and incorrect animation slots on the jerry can guitar
Fixed some inconsistent animation slots on the bass
Made a new keybind generator for the new full keyboard input mode
Fixed a note missing a MIDI code on the bass guitar
Generated default full keyboard binds for guitars, drums, flute, xylophone, tuba, trumpet
Jerry can guitar and acoustic guitar now use two different keybind short names (they have different notes)
Fixed LMB note playing all octaves instead of just one
Add instruments.debugNotes to print notes being played
Fixed some missing strings on piano and trumpet
Fixed some issues from the merge earlier, rebuild manifest to get instruments to show in compound
Fixed viewmodels not animating from midi input on cowbell and tambourine (input was too fast, is now updated via events)
Fixed bass vm not playing strum animations
Move MidiMapShortName to NoteBindingCollection (this ensures changes are propagated to the static compound variants of instruments)
Add new instrument shortname that we use to load autoplay recordings (this should fix compound instruments not being able to autoplay)
Updated default autoplay recordings to match new file name requirements (eg. bass.weapon_autoplay is now bass_autoplay)
Fix exception when playing a recording and the directory doesn't exist
Reapply compile fix
Fix NRE when using playrecording with no args
Fixed static instruments using outdated prefab ids (fixes missing instruments in compound)
Updated binding array for all notes on static piano
▋▆▍█▋ ▆▇▄▇ ▋█▋▋▇▊▉▉ ▆▋ █▅▌▆▋▋ ▍▊ ▄▉▋ ▋▍▆▄▆▋▉▋▇
More cleanup
If unable to find a recording when using playrecording, print out the options in the directory
Fixed repair costs not matching crafting costs on static instruments
Fixed piano not being able to play all of it's notes (note array needed to be regenerated)
Fixed piano deploy sound registered on the piano as D0
NoteSFXImporter now skips sound definitions with "mount" or "deploy" in their name
█▋▉▍ ▇▋▍▄ ▌▇▊█▉▄▆ ▄█▋█▋▉ ▍ ▅▉▉▅▇ ▊▆▅▇▋█▋ ▄▆ ▊▉▇▄ ▇█▊▌▅▌▅▇▋▊ █▇ ▌▍▌
▇▅▅ ▉█▄▄▄▊▊▅▌▅▄ ▌▋▊ ▉█▍▆█ ▌▌ ▇ ▍▊▇▋ ▉▉▆▊ ▊▇▅▄▅▍▌▌▍█▊
██▅▍▇▄▅ ▍▊▌▊▊▊ ▆▌▋ ▌▋▇▉▍▊ ▄▌█▅▆▊▊ ▇▌▋ ▉▊██▌▍ ▅▅▅▌▊▄▄▌ ▌▊ ▊▄▉▇▆▇█▌▇▇█
▅▇█▍▄▌ ▌▍▍▊▇▊▄▍▄▄▍▄, ▍▄▄▆▋▍▄▅, ▆▍▋▄▊▄ ▍▇▉▋▆, ▇▋▆ ▇▍▉▉▊▉▄█▆▆ ▍▄▅▉ ▊▍▊█▌▌ ▊▍▅▍▄▇▋▊▇▆▋
Fix shoulder bones not resetting scale properly when mounting
Fix Music Help UI NRE when the sharp modifier key is not bound
Fixed NRE and guitar not appearing when previewing the acoustic guitar in the workshop preview uploader
▌▆▊▍▋ ▊▊▌▅▉▄ ▋█▊▆▆▄▇▉ ▊▆ ▋▇▄▋▅▅▆, ▍▋█▇▆ ▍▊▅ ▊▌▇▆▊▄▉▍▆ ▆▇▆▍▇▇▋ (▍▊▌ ▄▌▉▆▉█▇)
Updated piano IK targets to work better across one octave when using the keyboard