branchrust_reboot/main/indirect_instancingcancel
432 Commits over 516 Days - 0.03cph!
Revert changes to shader includes
Reverted changes to supported shaders
Revert changes to ProjectSettings
Remove instancing support from all non-standard shaders
Some .FBX.meta I didn't catch because they were uppercase
Revert even more .fbx.meta and .mat files to the state they have on /main
Subtract all .mat changes to investigate artifacting issues
Subtract all .fbx.meta changes to investigate artifacting issues
Fixed InstancedDebugDraw instance and command buffers initially bound to zero
Revert ProjectSettings.asset
- Removed indirect_instancing.enabled toggle (was broken)
- Reverted all modifications to MeshLOD, MeshCull, RendererLOD, RendererBatch and other LODComponents
- Fixed and optimise debug diagnostics
- Use an array instead of a dictionary to store RenderKeys
- Added various toggles for controlling which parts of the system run during profiling
InstancedDebugDraw: Fix performance issue when re-adding instances each frame
Indirect instancing fixes:
- Supported shaders are no longer determined at runtime, instead a list is supplied to the component on the main camera prefab. This fixes issues where instanceable objects would end up in the non-instanceable fallback renderer.
- Add operations are no longer queued in order to return success/failure states immediately back to the caller.
- Remove operations are now queued without relying on managed references, fixing various use-after-destroy issues.
- Broadened the use of the InstanceCreationInfo struct to avoid fealing with so many function parameters.
- Improved logging when instances can't be added (1) at all or (2) only in the non-instanced fallback renderer.
- Fixed exceptions resulting from calling RecalculateUVDistributionMetric() after UploadMeshData()
Fixed removing the wrong instance when the swap-back-removal of another instance invalidated the indices by reintroducing instance sequence numbers, but slightly better.
Don't rely on managed references when removing instances, use InstanceHandle instead
Fix exceptions caused by removal of meshes with less materials than submeshes
A week's worth of fixes for indirect:
- Added a `spawnprefab` editor-only command that allows to spawn (and pre-process) any prefab for testing.
- Moved indirect ConVar stuff to a proper indirect_instancing.cs
- Temporarily removed Core/* shaders from the compatibility list because indirect support is unclear.
- Revamped the indirect compatibility decision logic to be more granular and robust.
- Fixed invisible models when a renderer in instanceable but none of its materials are.
- Fixed NRE when encoundering null materials.
- Added TryEnqueueAdd which gives feedback about when enqueing a renderer failed due to incompatibility.
- Downgraded assertion exception when a shader wasn't found to just a warning.
- Reworked RejectReason structure to a struct fully interoperable with bool.
- RustRenderer now remembers original shadow casting modes so that they can be restored when indirect rendering is disabled.
- Store errors reported by TryEnqueueAdd in RustRenderer for debug purposes.
- Automatically disable RustRenderer if object is a shadow proxy.
- Automatically disable RustRenderer if any submeshes are incompatible with either indirect or fallback rendering.
Fixed shader errors about missing implementations of vertInstancingSetup
Fix construction guide not appearing
Changed implementation to only render colour pass and leave shadow culling and rendering to Unity
Fixed various causes that could render meshes twice
Add queue system for adding/removing instances to prevent colliding with the jobs
Implement a fallback renderer for non-instanced draw calls based on Graphics.RenderMesh()
Disable only unsupported submeshes in MeshRenderers, not all of them
Re-enable texture streaming jobs
* Restore damage tracking for command and instance buffers
* Skip RemoveDestroyedMeshes() as it doesn't seem to be needed anymore and it was taking well over 3 ms
Improve performance in the hierarchical culling job by reordering the culling tests by cost
Fix wrong index calculation in ArrayEx.RemoveAtNoResize()
Improve handling of null meshes in RustRenderer auto conversion
Grow block allocations exponentially because linearily wastes more buffer space.
Implement ArrayEx.RemoveAt* utility functions
- Render all instanceable submeshes instead of rejecting the whole mesh
- Use real LOD thresholds instead of 5 meter increments
- Disable LOD fading to be reintroduced when LOD switching is stable
- Pass final Mesh instead of MeshFilter to instancing system to allow assets based on MeshLOD to work properly
- Restructure RustRenderer for more robust automatic conversion
- Fix invisible LODs by merging duplicate entries referring to the same Mesh
Fix frustum culling by skipping damage tracking as a temporary workaround
