branchrust_reboot/main/instrumentscancel
799 Commits over 184 Days - 0.18cph!
flute anims and override controller
Pass RPC into new PlayNoteRPC and StopNoteRPC on Key Controller
Fix RPCHandler not being assigned
Moved InstrumentKeyController RPC to InstrumentTool and StaticInstrument
Moved InstrumentKeyController components onto the weapon/mountables
Added UpdatePlayerModel virtual methods on HeldEntity and BaseMountable to modify IK while an entity is in use (removes an Update call on KeyController)
Update all instruments with new components
Manifest update
Removed some more xml comment blocks
Fixed CLIENT/SERVER compilation
Hooked up new jerry can guitar
Revert acoustic guitar to legacy guitar
Set icons to null on instruments that have no icon
updated the old guitar textures/mat
Cowbell world model + Icon
Update guitar with new model + Icon
From code review:
Move hand props to Key controller to solve sticks being left on player model during pool
They get positioned during IK pass and never actually parented to the player
From code review:
_mounted is now populated on the client and server, and GetMounted() is now a shared method
This removes the need for UsingPlayer so that was removed
█▋▌▍▋▊ ▅▍▅▆ ▊█▉▅▇▇▌▍▍ ▍▄▌ ▇▄▋▌▍▇ █▅ ▇█▉▋▅▆, ▍▊▋▅▌▋ ▉▋▊▇▄▇▋▊█ ▍▅▌▅▉▇▋ ▆▍▊▋█▍
Fixed icon import settings for new instruments
Added an ItemIcon Import settings preset
From code review:
Reset mountedSpineLookWeight
Removed some xml method comments
Disable saving on key controller child entities
Remove cachedPlayer and SetPlayer() from InstrumentKeyController
updated drumkit lod1 to look better in low setting
updated guitar textures/lod
tamborine holdtype setup
weapon prefab now using world model
tamborine player overide animator
base idle & play anim
fixed missing backface/holes on piano_lod0
fixed wrong normal on the guitar
adding guitar, world model + lods
adding guitar model/texture/mat
fixed gloss on the bass material
Icons for Trumpet, Flute, Tambourine, Drum Kit and Bass
Trumpet and bass are third person
Reparented instrument view point to spine_4 to work with trumpet hold type better
bass holdtype now uses bass model
trumpet holdtype setup with lods,
created override controller and added idle pose
added V and W tambourine models, set up prefabs and lods etc.
Merge from third person held
adding cowbell word model + lod
adding cowbell model/mat/textures
Allow some rotation around the locked camera perspective (about 20 degree son both axis) on static instruments
Exposed and lowered IK lerp speed
Added some editor handles for easier IK placement
Equip drumsticks when using drums
▋▋▆▉▅ ▇ ▆▊▊▄▇▌▋▇█ ▋▄▉▌█▄ ▋▌ ██▊▄▉▄▋ ▉▊▊█▋▌▅▍ ▅▆▅▅ ▋▊▇▌ ▍▌▍▉▆ (▉█▋▌▍▍▋▄ ▉▆ ▋▉▌▉▋▆▇)
splitting drumstick models
Rework drum kit prefab and build manifests
updated drumkit textures/mat, adding LOD/ gibs
▌▋▇▌▉ ▉▊▄▉ ▌▌▊▄▉▉▅ ▌▍█▍ ▋▉▍█▌▋█ ▄▇▅ ▆▅▌ ▍▌▅▄▇▅
Hook up drum kit materials
Remove change perspective RPC calls, do everything from client side perspective mountable callbacks
Hacky fix for getting stuck in third person after exiting instrument
