branchrust_reboot/main/instrumentscancel
700 Commits over 184 Days - 0.16cph!
Rework IK targets to support targets for the regular and sharp versions of a note
Added more right hand IK targets to drum kit
drumkit ik target updates
Add left and right hand prop rotation offsets for instruments
xylophone player anims and override controller
cowbell holdtype setup - held prefab now using lods, player override controller, initial player anims
adding xylophone lod, moving guitar model
adding WIP xylo
moving/renaming guitar texture/mat folder to the corresponding one
Fixed drum IK hits working in local space of IK target and not local space of instrument
Added a hit rotation vector that applies an IK rotation offset when hitting a note
separated cowbell models
fixed guitar normals
Exposed instrument keybinds in settings
Exception fixes
Exposed a default note to play on Primary and Secondary Fire
Can now create an arbitrary number of IK positions for an instrument
Added an IK target property drawer to help assign targets
Added context menu options to add left and right hand IK points
Added support for right foot IK control (for drumkit)
Left and Right Hand props can now be used if IK is disabled on the InstrumentKeyController (for cowbell hand setup)
Ignore stop note RPC on controlling player
old guitar textures tweak
flute anims and override controller
Pass RPC into new PlayNoteRPC and StopNoteRPC on Key Controller
Fix RPCHandler not being assigned
Moved InstrumentKeyController RPC to InstrumentTool and StaticInstrument
Moved InstrumentKeyController components onto the weapon/mountables
Added UpdatePlayerModel virtual methods on HeldEntity and BaseMountable to modify IK while an entity is in use (removes an Update call on KeyController)
Update all instruments with new components
Manifest update
Removed some more xml comment blocks
Fixed CLIENT/SERVER compilation
Hooked up new jerry can guitar
Revert acoustic guitar to legacy guitar
Set icons to null on instruments that have no icon
updated the old guitar textures/mat
Cowbell world model + Icon
Update guitar with new model + Icon
From code review:
Move hand props to Key controller to solve sticks being left on player model during pool
They get positioned during IK pass and never actually parented to the player
From code review:
_mounted is now populated on the client and server, and GetMounted() is now a shared method
This removes the need for UsingPlayer so that was removed
Fixed icon import settings for new instruments
Added an ItemIcon Import settings preset
From code review:
Reset mountedSpineLookWeight
Removed some xml method comments
Disable saving on key controller child entities
Remove cachedPlayer and SetPlayer() from InstrumentKeyController
updated drumkit lod1 to look better in low setting
updated guitar textures/lod
tamborine holdtype setup
weapon prefab now using world model
tamborine player overide animator
base idle & play anim
fixed missing backface/holes on piano_lod0
fixed wrong normal on the guitar
adding guitar, world model + lods
adding guitar model/texture/mat
fixed gloss on the bass material
Icons for Trumpet, Flute, Tambourine, Drum Kit and Bass
Trumpet and bass are third person
Reparented instrument view point to spine_4 to work with trumpet hold type better
