1,962 Commits over 488 Days - 0.17cph!
Update: UI_StoreItemGrid - allow grid to initialize it's tiles multiple times in a row
Tests: clicked between various tabs on the store in editor with bundle backend
Update: UI_StoreTakeover - Do not instantiate textures when loading from dynamic bundle
Lets us avoid destroy calls, since dynamic bundle unloading destroys things automatically
Tests: navigated to the store page in editor with bundle backend
Bugfix: ensure dynamic bundle tracks subscriber count accurately
This was causing the bundle to not unload in the updated flow
Tests: navigated to store in editor with bundle backend
Bugfix: ensure ui/store.bundle gets unloaded after all changes
- UI_Store opens the first tab during warmup, outside of OnOpen, which unbalanced subscribe/unsubscribe calls. It also never closed the tab when itself being closed. Addressed both.
Tests: clicked through tabs, then closed shop - no asserts fired. Need to test in bundle mode, that'll be next.
Bugfix: fix some items showing empty icons
Tests: navigated through all tabs of shop and inventory - everything seemed present
Merge: from fix_missing_takeovers
Images still missing - digging deeper
Tests: navigated to store
Update: run Update Paths and Assign Bundle on MenuUI2_Store_General grids
Tests: none, will test in parent branch
Bugfix: warm up UI_StoreTakeover's Takeovers in more cases
- Reimplemented warmup of StoreFeatured/General/Limited to first spawn empty tiles and fill them up once tab is opened
Turns out, we can open tabs of store without opening store itself, resulting in an access to uninitialize takeovers. Couple empty item icons remain, will fix next.
Tests: navigated to the store and clicked through bunch of tabs and scrolled around.
Update: break ItemStoreTakeover links to sprites
- Added warmup-cooldown to relevant UI screens
Doesn't work correctly - menu spawns, but uses wrong assets. This is due to warm-up logic running before storetakeover warmup
Tests: navigated to Store and Inventory pages. Inventory is okay, but store is derped
Update: UI_StoreTakeover.AssignStoreBundle utility to assign it's icons to ui/store.bundle
- Ran Assign Store Bundle on all takeovers
Tests: inspected meta changes
Update: ItemStoreTakeover - stores paths to icon textures
- Updated StoreTakeoverDrawer to visualize sprites from paths instead of ItemStoreTakeover fields
- ran update paths on relevant prefabs
Not decoupling sprite fields from ItemStoreTakeover just yet - gonna do it as a separate submit
Tests: interacted with prefabs in the editor, confirmed that it's rendering correct images and paths are present
Update: FilySystemBackend supports "dynamic" asset bundles
- updated store overlay pages to use it
Was able to succesfully load up Abyss store page, observed no stutters. Confirmed with memory profiler that abyss textures were loaded only on entering the page, but discovered that they remain afterwards despite unload (as they're still owned by asserscenes.bundle somehow) despite ui/store.bundle being unloaded. That'll be next.
Tests: used both normal and bundle backends in editor and navigated to Abyss page. Built a debug client and navigated to Abyss page, took snapshots. Built Release client to see if stutters are present.
Bugfix: fix UI_Takeover overriding with null values
Tests: ran in editor
Hack: skip explicitly loading ui/store.bundle at boot
Using this to check if we no longer have a bunch of media textures loading in. Memory Profiler shows -87 textures/-1.2GB loaded. Need to implement dynamic bundle loading, and see if it breaks anything else.
Tests: memory profiled a standalone client. Couldn't get to Abyss page (but that's expected).
Update: assign UI store overlay page prefabs to ui/store.bundle
- Ensure when we generate bundles, we chuck the assigned assets to ui/store.bundle
Tests: generated bundles, used bundle mode in editor and was able to navigate to the Abyss store page.
Update: UI_Store - drop UI_StoreItemOverlayPage references
- resaved prefab
Doesn't help with reducing RAM pressure, but allows us to take the next step of dnyamically loaded/unloaded bundles.
Tests: Went to Abyss page in Editor. Built standalone, took a memory snapshot from main menu - offending assets still there
Update: FileSystemBackend.Load<T> - option to skip caching of loaded asset
Using this to try to avoid caching of store assets
Tests: opened and closed Abyss page a couple times with DB backend
Clean: reorganize UI_Store.CloseStoreOverlayPage
- added a todo to revisit
Tests: none, trivial change
Bugfix: Ensure active UI_StoreItemOverlayPage gets properly cleaned up
Tests: tried a bunch of main menu interactions
Update: UI_Store - load overlay page dynamically from path
Doesn't do unloading yet (gets cached in the asset backend). Also there's a bug with CloseStoreOverlayPage not being called in all cases.
Tests: In Editor, loaded Abyss overlay page in store
Update: UI_StoreTakeover - store paths instead of guids
- ran Update Paths
Our filesystem backends only work with paths, so GUIDs were useless.
Tests: none, trivial change
Update: UI_StoreTakeover - store GUIDs to referenced prefabs
- Ran Update GUIDs on MenuUI2_Store
same goal as before, try to dynamically load/unload store pages.
Tests: In editor, opened Abyss store page
Update: Run "Update GUIDs" on all store overlay page prefabs
Tests: loaded Abyss store page in Editor
Update: UI_StoreItemOverlayPage - store GUIDs of textures
- Added utility to fetch GUIDs from already assigned textures and saving to disk
Getting ready to switch to guid resource tracking instead of relying on unity to always load textures
Tests: Loaded into bootstrap scene in editor and opened Abyss store page
Bugfix(editor): LoadMapFile - don't NRE when no scene is loaded and Server Occlusio Debug is open
Tests: used in editor
Merge: from server_occlusion_poppin
- Bugfix: fixes false-negative occlusion queries at the top of the hills
- Bugfix: fixes false-positive occlusion queries while looking through a hill
- Optim: sped up occlusion cache generation by 65%+ (4.5k from 134s -> 50s, can be faster with sufficient RAM)
- Editor: extended LoadMapFile with Server Occlusion debug tools
Tests: generated reported bug case and visualized and debug traced. Generated 6k, 4.5k, 2k and Craggy to confirm generation doesn't crash.
Buildfix: don't try to draw on the server-only build
Tests: editor compiles
Clean: code cleanup and custom_occlusion_query command
- ran generate code
Tests: compiles in editor
Optim: ServerOcclusion - try to avoid redundant HasCustomTag calls
Only saves 1s out of 30s run, but should scale better if we increase GridOffsets in the future.
Tests: generated and visualized
Optim: ServerOcclusion - split work in batches and process them serially
This reduces RAM pressure and possible paging, but still generates enough work for CPU (8mil subgrid cells per batch) to keep it busy. 4.7k generation times went from 50s -> 30s. Gonna clean up and merge.
Tests: generated and visualized
Optim: ServerOcclusion - jobify a bit more + use ScheduleParallel
4.7k map generation time goes from 69s -> 52s, stopping here. I'm likely getting diminishing returns on my PC due to heavy paging (generation takes 8GB+ ram) - will break it down next.
Tests: regenerated and visualized cache
Optim: ServerOcclusion - convert rest of narrowphase to Burst
- Replaced couple NativeList inside TestInsideTerrain with NativeArray to avoid 2GB limitation. Need a different solution for 7k maps
4.7k world generation time went from 130s -> 69s. Longest part is OcclusionIncludeRocks now (47s)
Tests: regenerated occlusion on 4.7k world, then visualized the grid
New: TestInsideTerrain - Burst version
- added unit test
Tests: ran unit test
Optim: ServerOcclusion - convert OcclusionIncludeRocks part of narrow phase to Burst
Total generation time went from 240s -> 130s. There's still 80s worth of TestInsideTerrain to rewrite
Tests: regenerated and visualzied in editor
New: AreInsideMesh - burst versions of IsInsideMesh
- added unit tests
Tests: ran unit tests
Bugfix: ServerOcclusion - don't ignore rocks that are close to the center of a subgrid cell
Tests: regenerated and visualized in editor - seemed sensible, no gaps observed
Optim: ServerOcclusion - rewrite cache generation broadphase to use parallel jobs
- Takes broadphase from 4.8s to 0.4s
This is tiny, since narrow-phase is the longest (on my 4.7k test map total time is ~240s). I'll do narrowphase next.
Tests: generated on a custom map and visualized the occlusion grid
Bugfix(editor): LoadMapFile - check for relevant state after domain reload to allow occlusion cache rebuild
Tests: triggered a couple reloads, no NREs when generating cache
New: added GamePhysics.CheckBounds that uses parallel Burst jobs
- added unit test to validate it
Tests: ran unit tests
Bugfix(editor): LoadMapFile - ensure terrain state is setup after domain reload when we generate server occlusion cache
Tests: ran generate server occlusion cache after code edits
Clean: missed newlines
Tests: none, trivial change
New(editor): LoadMapFile - added Server Occlusion Debug section
- refactored ServerOcclusion.DebugPath to not draw anything and just gather cells traced
Allows to debug occlusion bugs without having to enter play mode
Tests: used the tool in the editor, confirmed it compiles in SERVER+CLIENT and SERVER envs
Bugfix: ServerOcclusion - Save an extra grid chunk of data if our topside neighbor has terrain
- Added versioning to the occlusion cache file
This avoids the hollow terrain problem at the expense of a bit more memory use. Need to optim the impl - it doubles phys queries, so doubles generation time
Tests: used custom_occlusion_query and validated cases that previously incorrrectly passed
Debug: ServerOcclusion - for player_occlusion_subgrids, show cached info as well
This shows the reason why it's possible to see through terrain at specific angles - our "narrow passages" approach get into hollow terrain
Tests: used above to fly around and inspect the world
Debug: ServerOcclusion - add occlusion_blocked_cells and custom_occlusion_query editor convars
- occlusion_blocked_cells visualizes all blocked cells nearby
- custom_occlusion_query allows to setup a query via 2 gameobjects in the editor(in play mode)
- restored player_occlusion_subgrids
Tests: used the commands
Bugfix: ServerOcclusion - don't block visibility if there's one blocked string passage
This fixes edge-cases around hills, but there's still an issue of being able to see through hill - investigating
Tests: used player_occlusion_subgrids to test a bunch of paths
Debug: changed up player_occlusion_subgrids to render results from ServerOcclusion.Algorithm.Gather
- Gather now also marks if it used the neighbour passage or direct path or was blocked
- Gather respects various convars
Think I see what the problem is - my recent algo changes have a bug with neighbour passages. Investigating further
Tests: used above server var to visualize paths
Bugfix: LoadMapFile - assign Terrain layer to created terrain
Required for server occlusion
Tests: recreated the scene, now server occlusion cache generation works
Debug: ServerOcclusion - use manually controlled points to define a query in server-editor during playmode
- don't use cache, use phys queries directly (for what-ever reason cache is borked on this custom map, will investigate later)
Written as throwaway, will clean up at the end
Tests: visualized the path of one of the poppin cases
