1,914 Commits over 457 Days - 0.17cph!
Merge: from main
Didn't refresh and missed the desired fixes
Update: skip server occlusion culling for players in the deep sea
It'll still have some overhead for the server occlusion processing, but that'll be improved separately
Tests: 2p session on craggy - tested occlusion with both on Craggy, one on Craggy and one in deep sea, and both in deep sea
Bugfix(editor): StoreBundleTool - handle invalid paths
This can happen if the serialized path now points to renamed or deleted resource.
Tests: none, don't have a case like that right now.
Update(editor): StoreBundleTool - stage timings emit volume of work
Makes it easier to confirm if it's doing anything when there are no dirty changes
Tests: ran the tool
Clean(editor): remove Tools/Menu2
Checked both the editor pref by variable and by value, they're not used anywhere
Tests: none, trivial change
Update(editor): StoreBundleTool - scan scriptable objects
- fix assembly scanner skipping public fields if it's type is nested
Tests: created a dummy scriptable object, ran a scan - it got picked up
Updateeditor): StoreBundleTool - activate bundle assignment code
- removed extra logging
Tests: editor compiles
Update(editor): StoreBundleTool - scan for already-assigned-to-bundles resources
- fixed timer reporting invalid times for sections of code
Tests: ran it, doesn't find any diffs with my manual assignments from last month
Update(editor): StoreBundleTool - add proxy path scanning from existing prefabs
Tests: ran the code, checked some of the paths. gotta implement comparison to fully validate
Update(editor): StoreBundleTool - add support for array traversal
Tests: ran the tool, it found all annotated fields
Update(editor): StoreBundleTool - properly implement reflection shortcutting
Tests: stepped through how it's accumulated. will test more later
Update(editor): start of StoreBundleTool - automates bundle assignment for properties with ProxyPathFor attrib
- starting with assembly scanning
Idea is to scan the assembly, detect all the relevant fields, resolve them and assign referenced assets to the bundle
Tests: ran it, doesn't find all fields yet
Merge: from baseplayer_vis_nre
- fixed false positive logging, better logs
Tests: built standalone and connected to staging server - no extra errors on connect
Update: move breadcrumbs a bit to get better callstack
- eliminated a false-positive
Tests: built standalone and connected to staging - no more error logs on connect to server
Buildfix: add missing namespace using
Tests: none, trivial change
Merge: from analytics_track_menu_times
- Client analytics now aggregates frametimes, lag spikes and gc events into InGame, MainMenu, Inventory, Crafting, Contacts and Map groups
- Skip sending lag spikes and gc counts if there were none during performance logging tick
Tests: observerd client_perf analytics ticks in editor with debug code
Clean: remove unused namespace using
Tests: none, trivial change
Clean: remove debug logging
Tests: compiles in editor
Optim: don't emmit lag spikes and gc counts if there weren't any during analytics ticks
Tests: observed couple client_perf ticks in editor
Bugfix: no more use-after-free for Frametimes
- also reimplemented the fix from previous CL, as it was part of the problem
Tests: in editor spawned on craggy and opened main menu for multiple client analytics ticks - no more exceptions
Update: Client Analytics - categorize client frametimes, gc_count and lagspikes
- Bugfixing leaking a couple List<TimeSpan> containers
We now filter those out to InGame, MainMenu, Inventory, Crafting, Contacts and Map frame types and aggregate per type. Everything apart from InGame aggregates slightly reduced info set. New analytics is backwards compatible.
Tests: left it running with debug logging. relevant info seems to come through. There's a bug with use-after-free of List<TimeSpan> - will fix next
Update: convert error logs to error-once logs
The current changes mitigate the problem, which will allow peeps to play longer while we chase up what's going wrong.
Tests: none, trivial change
Update: adding more logging in an attempt to catch baseplayer NREs
Tests: 2p local session with spectating, disconnects
Clean: leaving a TODO note for one I return to this
Update: if either logging or dry run is enabled, log uploader activity
Previously it was editor only, and you had to enable dry-run specifically to get those logs. This makes it easier to work with.
Tests: none, trivial change
Bugfix: in editor with SERVER+CLIENT send client records to client gameplay AnalyticsTable
Not sure if it's technicall bug, but it did differ from original logic
Tests: logged activity in the editor
Optim: wind down AzureAnalyticsUploader when UseV2 is active
Gets rid of async tasks that are generating allocs while waiting for work
Tests: in editor activated v2, waited till upload happens, then disabled and waited for normal upload
Update: name the analytics thread
Tests: dry run in the editor
Optim: reduce allocations by relying less on async/await
- Use a Thread instead of a Task for internal AnalyticsManager work (this also fixed editor 10s shutdown delay)
- Allow internal upload tasks to run in parallel instead of waiting on sequential completion
Previously it would frequently GC, now it's back to normal
Tests: ran in editor in dry run mode. ran unit tests
Update: add profiling markers to AnalyticsManager and it's uploaders
Tests: ran in editor
Update: FPUploaderImpl - add a warning in case someone attempts to feed it non-json AnalyticsTable
Tests: none, trivial change
Update: append AnalyticsTable name when logging accumulator activity
Tests: none, trivial change
Update: accumulator log now also outputs byte size (pre compression if there is one)
Tests: none, trivial change
Bugfix: fix false "EventRecord pooling error" when disabling analytics.usev2
Hoping to rip it out once we fully convert to v2
Tests: unit tests + enabled-disabled in editor
Update: move analytics-for-server shutdown to ServerMgr.CloseConnection
This shuts down server before steamwroks in SERVER+CLIENT editor - makes editor's lifecycle management less confusing
Tests: confirmed client session end event still fires in editor
Bugfix: ensure session end event gets enqueued for V2 analytics
Tests: monitored in editor, saw it when stopping player
Clean: move new implementation into it's own file
Might split it up further, but not needed for now
Tests: editor compiles
Bugfix: respect rate limiters of AnalyticsTables and avoid mixing data when uploading
- Fixed by creating an accumulator per AnalyticsTable that's managed by uploaders
I need to profile and work on allocs, but it seems to be working
Tests: unit tests and monitored client telemetry
Update: Integrate the new AnalyticsManager into existing logic
- Guarded by `analytics.usev2` (default off for now)
- Bugfix for rate-limiting being disabled due to mixing Now and UtcNow (whoops)
- Added global `analytics.dryrun` and `analytics.log`
Did a cursory test in editor using dry running and it seems to be working, but it leaks performance data into player_tick blobs. Need to reorganize accumulators again - always-aggregate isn't always valid.
Tests: used above switches and monitored data flow.
Update: Add FallbackUploader - uses primary uploader if enabled, otherwise uses fallback
- Added a test that checks it
- DryRun is now a per-accumulator settings instead of a global overwrite - lets each uplaoder decide how to act
Allows us to setup flexible chains(extra loggers, backups, etc), and more importantly we can emulate current analytics flow
Tests: ran unit tests
Update: Move accumulators into uploaders
- AnalyticsTests.TestUploade has logging enabled permanently to help validate things
It was a blocker to implement uploader chains (which I discovered we need for server, but should be quick)
Tests: ran unit tests
Clean: rename AnalyticsUploader -> AnalyticsManager
Disambiguates from the internal IUploader
Tests: compiles in editor
Bugfix: apply separator in json-lists aggregation correctly
Tests: used accumulator logging to see what is being fed
Update: Accumulators can now log what they're being fed
This revealed a bug with json concatenation, should be a quick fix
Tests: ran unit tests
Merge: from server_occlusion_gen_reorder_narrowphase
- Bugfix for ServerOcclusion potentially crashing during generation
Tests: generated custom map that had a consistent crash and a default 4.5k procgen editor world
Bugfix: ServerOcclusion - don't schedule same SubGrid cells repeatedly for rock intersection
It caused more work to be done(this saves ~13s), and in some cases even an out-of-bounds access crash.
Tests: generated server occlusion cache for a 6k custom map that had a consistent crash, generated default editor 4.5k proc gen world
