5,916 Commits over 1,584 Days - 0.16cph!
Set room occlusion and the admin bypass for it to be saved in editor
- avoid us having to keep turning it on & disable the admin bypass every time we enter play mode but keep the feature disabled by default in standalone builds
Add support for convars to only be saved in the editor
merge from main -> base_occlusion
▌▍ ▉▊▇▇▆▆ ▄▄▍▋▅ ▋▊▌▌▋ ▉▇▋▋▊█ ▉▍▊▊ ▌▅▉▆▉ ▊▉▌▉▆▋█▅▅▊▆▄▍ █▄▌ ▌ ▋█▆▍▌▄ ▇▅▅ █▋ ▉▇▌█▊▅ ▉▅▌ ▆▊▍▅▆ ▊▄▇▇▉█▉▋▄ █▄▄ ▊▋▉ ██▅▇▊▉▌▋▋▇ ▋▍▌▄▉▅█▄▋▆▍▍▋ ▉▍▆ ▌▇██ ▊▉▋▊▇▌▉▊ █▊▌▇▊▍▌▉ ▊▋▉▆▉▍ ▍▉▉▉▊▉ ▇█▋█▆▇
Optimizations
- add spatial grid for rooms (just like network grids) so we don't murder performance networking every room within 32m (because we actually testing this large scale now, not craggy)
- fix every room being checked on the server instead of only the room that the entity was deleted from
Make sure that disabling room occlusion after enabling it cleans everything up
- we want all face definitions to be destroyed after disabling so we can re-initalize everything properly
- if initialization fails, only try once instead of getting stuck trying every frame
Add base occlusion to runtime profiling so we can monitor how much main thread time it spends on room occlusion per frame
Improve the warning if the spatial network grid IDs will overlap the reserved room ids
- change the encoding from hardcoded values to constants (confirmed behavior is identical)
Make room network group IDs static similar to the other reserved values instead of instance field
- first 1024 IDs are for global groups
- last 6.5M IDs reserved for base occlusion
Cleaned up entity face registeration so only BaseEntity calls RoomOcclusionManager.OnFacesRefreshed(entity)
- used to subscribe to both DecayEntity and BuildingBlock so it could work on doors & building blocks
- get rid of needing to register all faces explicitly in SaveRestore & copy paste
Update doors to only call into base occlusion when their open/closed state is changed (via flags) instead of needing to remember 3x different places it called into base occlusion
Cleanup network subscription logic so it all happens in a single place
merge from main -> base_occlusion
▄ ▊▊▌▋▌ ▌▅█▍ ▄▊█▋▇█▋▍▉█▋▆▆█▇▉▇▄▍▄▇▄▅▇▋▌ ▍▋ ▉▌▌▊
▉ ▇▍▊▇▄█ ▊▇▉▇ ▌▋ ▆▊▋▇ ▇▉ ▄▊▍ ▅▅▆ ▍█▇▊▆▍ ▋▋▇ ▇▋ ▄▄█▇▄ ▇▍▇▍▄▉▆▋▍ ▌▋▇▉▋▉▆▋ ▇█▉▄▍ ▅▊▉▄ █▌▌▊▆▍ ▆▄ ▆▄ ▋▅▅▇▆ ▊▋█▆█▆ ▉▌█▇ ▊▄▌ ▄█▌▋█▍ ▅▇▌▆▉▋ ▄▉▉ ▉▉ ▉▆▄▆▇▅▊█ ▄▌▌▄▇ ▇ ▉▍▇▍▌
▋ ▅▆▆▇▇▉▄▍▉▆ ▆▆ ▉▍▍▊▉▆ ▌▅▆▆▇▅▌▄▉▊▇▌▌ ▇▄ ▉▆▍▉▉▄▊▇▊▅▅▇▌▅▊█▉▋▇▇▉
merge from fix_automated_test_game_view -> main
Fix automated test runner not working if the test runner window is open when play mode is entered
- caused by WaitForEndOfFrame() in a coroutine stalling until the game renders the next scene
- instead of chaing every usage of that in the project (and the side effects it may cause) make the test runner window focus game view
▅ ▄▌▍▌█ ▆▍▄▍ ▆▄▋▄ ▉▍ █▍▆▍▉▊▄▅▅▉▅▍▋▇▆▍▇▆▇▅▇█▅▆▇▇
merge from fix_recursive_log -> main
- fix InvalidOperationException from iterating through connections while closing socket
- prevent extra error messages from being logged after a connection is closed as the connection is kicked after any exception
Add tests to prove the threaded logging system is still working with the new fix
Add 10k queued log message cap & prevent exceptions thrown while sending messages to RCON from being logged to RCON itself
- unity already protected against main thread log callback calling invoking the callback recursively but we need extra protection for RCON
▊▊ ▋▊▊▅▅ ▍▄▌▅ ▅▅▆▄▆▄▊ ▋▍ ▋▇▌▅▆▍▇ ▋▋▊▄▍▋ ▇█ ▉▇▌ ▆▇▉▌▆▇▅ ▉▅▄▌ ▇▉▇▄█▄▆ ▋▉ █▊▌▇▆▇▌ ▅█▌ ▌▉▌▅▇██▍ ▄▉▍▊ ▌▆▍█▅▊▌▆▆▅▋▋▇ ▉█▆ ▉▌▉▍▅▇ ▆▇ █▇▍▊ ▄▅▅ ▆▊▋▌▊▇▋▆▅▆ ▅▉▊▋▄ ▌▋▍▆▇▆ ▍▍██▄ ▊▍
merge from fix_editor_logthread_nre -> main
Add try catch to the OutputHandler so if an exception SOMEHOW happens it can't kill the process (since it runs in the finalizer thread)
Fix log thread throwing ObjectDisposedException in editor
- also fix the Task exceptions not being flattened fully
merge from sentry_upload -> main
Re-add the "max 3 uploads per session" logic that got removed accidently
Add missing catch {} to a try statement that only had a finally {} block
Fix HttpContent being double disposed
merge from main -> sentry_upload
- fix reading tail of log not truncating extra bytes
- fix log files >5MB being skipped over instead of the tail uploaded
Tests for new way of reading logfile
- switch from writing sentry tags to disk and trying to link them to crashes to putting the sentry tags in the log file and parsing them when uploading the crash
- upload the last 100KB of the logfile instead of the whole thing
- cleanup
merge from main -> sentry_upload
▋ ▇▄▆▇█ ▉▅▌▍ █▇▋▉▋▊▋ ▍▉ ▇▄▍▋█▋▆ ▇▄█▇▌▅ ▆▊▆▋█▊▊█ ▌▋▋ ▊▉▇▌▍ ▌ ▌▉▍▅▄▄▋▉▊█ ▄▅▉▊█▅ ▇▄ ▅▆▄▆▅▆ ▄█▇▆▄ ▍█▇ ▇▆▉▌▌▄▆▉ ▉▅▌▆▊ ▇▇▄▇█▅▆▋ ▊▋▊█ ▋▄▉▋▉█ ▊▍▊▋▇ ▅▉▇▆ ▋▊▋▌█▌▊▋
Cherrypick CS
163721 (the command to test crash uploads) to the newer branch
merge from main -> sentry_upload
Don't kick for errors on background threads
Refactor Output.OnMessage() so it passes a single struct parameter instead of (message, stacktrace,logLevel)
- if I'm gonna to refactor it to add a 4th parameter, may as well make it a single class/struct passed
- allows a bool to be passed for "if it was sent on a background thread or not"
Update existing console tests to account for new behavior
Prevent the downgrade in the editor since it doesn't result in kick
Lower error level from exception -> warning on the client on background threads so clients don't get kicked from random exceptions
- keep it on server since it's only used for logging
